fix(metadata): strip directory prefix when converting nested .md link to .html#768
fix(metadata): strip directory prefix when converting nested .md link to .html#768TusharThakur04 wants to merge 2 commits intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Adds a safeguard to skip rewriting any link that already includes a protocol (e.g. Reviewed by Cursor Bugbot for commit f2f1fc1. Bugbot is set up for automated code reviews on this repo. Configure here. |
avivkeller
left a comment
There was a problem hiding this comment.
Can you elaborate on this?
|
earlier a markdown link such as this pr strips the directory prefix |
|
But doesn't this break cases where a full URL is needed? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
==========================================
- Coverage 78.43% 78.01% -0.42%
==========================================
Files 157 159 +2
Lines 13962 14112 +150
Branches 1152 1157 +5
==========================================
+ Hits 10951 11010 +59
- Misses 3006 3097 +91
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
i can add guard for |
Description
This PR reinforce the link conversion logic for nested .md files by stripping the directory prefix.
Validation
before :
Screencast.from.2026-04-14.05-00-18.webm
after :
Screencast.from.2026-04-14.04-36-15.webm
Related Issues
n/a
Check List
node --run testand all tests passed.node --run format&node --run lint.